Fix: Fire suppression keycheck and custom output name#27
Merged
Conversation
- matched key (recovery_day['building'] -> ['fire_suppression']). this matches matlab code. - amax to fmax to fix array size reduction and element-wise matching. this fix is previously precedented in commit 1522d04
- Added --output_file optional argument to cli parser with default 'recovery_outputs.json' - Condensed default behavior in driver.py from None -> if None -> string to 'recovery_outputs.json'
Collaborator
|
I agree with these changes. I just tested the changes on model |
dustin-cook
approved these changes
Apr 28, 2026
dustin-cook
left a comment
dustin-cook
left a comment
Collaborator
There was a problem hiding this comment.
This looks good to me and good catch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an error that exists when examples are ran with
fire_watch=False. This raises a call inother_functionality_functions.pywhere an undefined key in therecovery_daydictionary was referenced.Additionally, this PR allows for an optional filename to be passed to
run_analysis. This allows users to output results in alternate names other thanrecovery_outputs.json, as is often the case when batch running multiple iterations of the same input.Changes:
fire_suppressioninrecovery_dayofother_functionality_functions.py. The previous keyrecovery_day['building']['fire']did not exist.driverandclinow support an optional argumentoutput_file, defaulting torecovery_outputs.json